Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jet] raise error occured in embed() #365

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[jet] raise error occured in embed() #365

merged 3 commits into from
Mar 20, 2024

Conversation

ReneWerner87
Copy link
Member

@ReneWerner87 ReneWerner87 commented Mar 20, 2024 •
edited
Loading

Code/idea from #364 (comment)

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling in the rendering process to ensure errors are properly handled during template execution and layout rendering.
  • Tests
    • Added a new test to verify error handling when rendering a template with missing data.

@ReneWerner87 ReneWerner87 added the ☢️ Bug Something isn't working label Mar 20, 2024
@ReneWerner87 ReneWerner87 requested a review from a team as a code owner March 20, 2024 12:08
@ReneWerner87 ReneWerner87 requested review from gaby, sixcolors and efectn and removed request for a team March 20, 2024 12:08
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@ReneWerner87 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 32 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 913c1a2 and b196311.

Walkthrough

The recent update focuses on enhancing error handling during the rendering process in the Engine struct, specifically within its Render method. It improves how errors are managed when executing templates and rendering layouts. Additionally, a new test ensures that an error is properly returned when a template is rendered with missing data, reinforcing the robustness of the rendering functionality.

Changes

Files Summary
jet/jet.go Modified error handling during template execution and layout rendering in the Render method.
jet/jet_test.go Added Test_Layout_Error to verify error return when rendering a template with missing data.

"In the world of code, where errors hide,
🐰 A rabbit hopped, with a stride so wide.
With a tweak and test, it sought to ensure,
No bug could linger, no flaw endure.
🌟 Through templates and layouts, it made its mark,
Ensuring errors met, not a question mark.
In the land of Jet, it danced, so spry,
A coderabbit's work, never shy."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Mar 20, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 230285a and 9c31dc4.
Files selected for processing (2)
  • jet/jet.go (1 hunks)
  • jet/jet_test.go (1 hunks)

jet/jet.go Outdated Show resolved Hide resolved
jet/jet_test.go Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot reviewed Mar 20, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9c31dc4 and 913c1a2.
Files selected for processing (1)
  • jet/jet.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • jet/jet.go

@ReneWerner87 ReneWerner87 merged commit ff49b17 into master Mar 20, 2024
20 checks passed
@gaby gaby deleted the jet-raise-error-occured-in-embed() branch March 20, 2024 12:51
@gaby gaby mentioned this pull request Mar 20, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@gaby gaby Awaiting requested review from gaby gaby is a code owner automatically assigned from gofiber/maintainers

@sixcolors sixcolors Awaiting requested review from sixcolors sixcolors is a code owner automatically assigned from gofiber/maintainers

@efectn efectn Awaiting requested review from efectn efectn is a code owner automatically assigned from gofiber/maintainers

Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReneWerner87